Change Ambiguous Import error in Typer to case class #2362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
May 8, 2017
| val msg = | ||
| s"""|reference to `${hl"$name"}` is ambiguous | ||
| |it is both ${bindingString(newPrec, ctx)} | ||
| |and ${bindingString(prevPrec, prevCtx, " subsequently")}""".stripMargin |
There was a problem hiding this comment.
You can use i""" instead of s""" and drop the .stripMargin here.
| val kind = "Reference" | ||
|
|
||
| val explanation = | ||
| hl"""|The compiler can't decide which of the possible choices you |
There was a problem hiding this comment.
We need better integration of formatters. It seems non-sensical that we either get explanations of duplicated values (in ex) or syntax highlighting (in hl) but not both. That's just a side remark, intended for a future PR.
There was a problem hiding this comment.
I agree, the current formatters don't compose well. @felixmulder and I discussed the need automated line wrapping as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another more structured error message with hopefully helpful explanations.
@odersky I tried to trigger
error(em"reference to$nameis ambiguous; it is imported twice ...in Typer.scala:206, but the existing tests all end up in the error detection I now changed. Do you know of an example for that path?